Merged
Conversation
93c1a4c to
0b53abf
Compare
kbendick
approved these changes
Sep 27, 2020
Contributor
kbendick
left a comment
There was a problem hiding this comment.
This is a great catch. Thanks for taking care of this @chenjunjiedada.
Contributor
|
Thanks, @chenjunjiedada. I agree, this should be UTF-8. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR set the
javadoctask encoding option since the build task fails on the system that uses ascii. For example, we can reproduce the issue when settingjavadocencoding toASCII.I don't update the quote character here, it should be updated, though.