Skip to content

Fix javadoc encoding#1518

Merged
rdblue merged 1 commit intoapache:masterfrom
chenjunjiedada:fix-javadoc-encoding
Sep 28, 2020
Merged

Fix javadoc encoding#1518
rdblue merged 1 commit intoapache:masterfrom
chenjunjiedada:fix-javadoc-encoding

Conversation

@chenjunjiedada
Copy link
Collaborator

The PR set the javadoc task encoding option since the build task fails on the system that uses ascii. For example, we can reproduce the issue when setting javadoc encoding to ASCII.

> Task :iceberg-orc:javadoc FAILED                                                                                                                         
/home/cjj/iceberg/orc/src/main/java/org/apache/iceberg/orc/ORCSchemaUtil.java:233: error: unmappable character for encoding ASCII                          
   * which would then use its schema evolution to map that to the writer??????s schema.                                                                       
                                                                        ^                                                                                  
/home/cjj/iceberg/orc/src/main/java/org/apache/iceberg/orc/ORCSchemaUtil.java:233: error: unmappable character for encoding ASCII                          
   * which would then use its schema evolution to map that to the writer??????s schema.                                                                       
                                                                         ^                                                                                 
/home/cjj/iceberg/orc/src/main/java/org/apache/iceberg/orc/ORCSchemaUtil.java:233: error: unmappable character for encoding ASCII                          
   * which would then use its schema evolution to map that to the writer??????s schema.  

I don't update the quote character here, it should be updated, though.

Copy link
Contributor

@kbendick kbendick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great catch. Thanks for taking care of this @chenjunjiedada.

@rdblue rdblue merged commit f95bca7 into apache:master Sep 28, 2020
@rdblue
Copy link
Contributor

rdblue commented Sep 28, 2020

Thanks, @chenjunjiedada. I agree, this should be UTF-8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants