Core, REST: Add support for overwrite in RegisterTableRequest#15248
Core, REST: Add support for overwrite in RegisterTableRequest#15248adutra wants to merge 1 commit intoapache:mainfrom
Conversation
The "overwrite" parameter was added in apache#12239 to the REST spec and the Python client, but the Java RegisterTableRequest wasn't updated accordingly.
|
Note: there is actually no support for ovewrite in Java code. I refrained from implementing anything here since there were concerns about the right API to do so: https://lists.apache.org/thread/b5k7vdng904zr3n3q8wv83y8l30rnd4c So, this PR only adds support for JSON serialization, thus enabling catalogs to provide support for this feature if they have a way of doing so. |
singhpk234
left a comment
singhpk234
left a comment
There was a problem hiding this comment.
LGTM, Thanks @adutra
I believe since the java based IRC servers simply reuse these parser to deserialize the response from the client, this could come handy
it would be nice to make the PR title as Add support for overwrite in RegisterTableRequest Model
| .name(name) | ||
| .metadataLocation(metadataLocation) | ||
| .build(); | ||
| ImmutableRegisterTableRequest.Builder builder = |
There was a problem hiding this comment.
nit: is it possible to put them in one line if we are using var?
|
Hi @aihuaxu, would it be possible to include this in the coming release 1.11? |
5 participants
The "overwrite" parameter was added in #12239 to the REST spec and the Python client, but the Java
RegisterTableRequestwasn't updated accordingly.