API: Implement properties method in EncryptingFileIO #15289
Merged
+16
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huaxingao
approved these changes
Feb 11, 2026
Contributor
|
LGTM cc @ggershinsky |
singhpk234
reviewed
Feb 11, 2026
Contributor
singhpk234
left a comment
singhpk234
left a comment
There was a problem hiding this comment.
The change looks good to me, do you have any use case my mind where you would need these props ?
Member
Author
|
@singhpk234 Yeah, I encountered an UnsupportedOperationException while adding support for table encryption in the Starburst engine. |
singhpk234
approved these changes
Feb 11, 2026
Contributor
|
Thanks @ebyhr for the change, Thanks @huaxingao @ggershinsky for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suppose this is an oversight.
If we omit the override, it may cause an exception once we add support for table encryption in Trino/Starburst because of ForwardingFileIo.