Add null check when calling catalog.close in SparkTestBase#1529
Merged
rdblue merged 1 commit intoapache:masterfrom Sep 30, 2020
Merged
Conversation
Contributor
|
Thanks, @kbendick! |
Member
|
Thanks for taking care of this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As pointed out by @RussellSpitzer in his PR https://github.com/apache/iceberg/pull/1525/files, there is the possibility that the catalog is null when the tests are running. This error likely come from killing tests early while debugging, but that's something that probably a good handful of us do in our workflow and this will make the output less verbose.
I've cherry picked this change from his PR, as that PR will likely take much more time to merge in due to its scope and the community can benefit from this fix now.