BigQuery: Add retry detection for idempotent commit handling#15308
Open
joyhaldar wants to merge 1 commit intoapache:mainfrom
Open
BigQuery: Add retry detection for idempotent commit handling#15308joyhaldar wants to merge 1 commit intoapache:mainfrom
joyhaldar wants to merge 1 commit intoapache:mainfrom
Conversation
8c5f840 to
decc695
Compare
decc695 to
9829ac3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds retry detection to BigQuery Metastore table commits to handle cases where a commit might have succeeded but we received an error, for example, a network timeout after the request reached the server.
When retries occur during
createorupdate, an earlier attempt may have actually succeeded. Without checking, we might incorrectly report failure or attempt duplicate commits. This addresses the existing TODO in the codebase.Changes
RetryDetectorutility that wraps callables and counts invocationscreate(Table, RetryDetector)andupdate(TableReference, Table, RetryDetector)methods toBigQueryMetastoreClientBigQueryTableOperations.doCommit()to usecheckCommitStatuswhen neededcleanupMetadata()helper methodNotes for Reviewers
RetryDetectorwhich wraps the create and update callables to count invocations.RetryDetectorobject tocreateandupdatecalls, I added overloaded methods in BigQueryMetastoreClient.java. The 1-arg versions delegate to the 2-arg versions.RuntimeIOExceptionbecause convertExceptionIfUnsuccessful() already converts HTTP errors to specific Iceberg exceptions.RuntimeIOExceptionwrapsIOException, which are network failures where we don't know if the request reached the server. Other exceptions likeCommitFailedExceptionorAlreadyExistsExceptionare definitive server responses, so no need to check commit status for those.