CI: Fix recurring and dispatch JMH benchmarks#15488
Closed
naamamaoz wants to merge 0 commit intoapache:mainfrom
Closed
CI: Fix recurring and dispatch JMH benchmarks#15488naamamaoz wants to merge 0 commit intoapache:mainfrom
naamamaoz wants to merge 0 commit intoapache:mainfrom
Conversation
nastra
reviewed
Mar 2, 2026
nastra
reviewed
Mar 2, 2026
jmh.gradle
Outdated
| includeTests = true | ||
| humanOutputFile = file(jmhOutputPath) | ||
| jvmArgs = ['-Xmx32g'] | ||
| jvmArgs = ['-Xmx8g'] + (project.property('extraJvmArgs') as List<String>) |
Contributor
There was a problem hiding this comment.
this change doesn't seem related?
nastra
reviewed
Mar 2, 2026
.github/workflows/jmh-benchmarks.yml
Outdated
| path: | | ||
| **/benchmark/*.txt | ||
|
|
||
| merge-results: |
Contributor
There was a problem hiding this comment.
can you please elaborate why this is needed now?
Contributor
|
@naamamaoz you should be able to run these changes in your fork to verify that JMH benchmarks pass again. Can you please attach some links that show this works? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JMH benchmark workflows have been broken since the default Spark version moved past 3.5.
This PR fixes three issues:
-DsparkVersions=3.5so the Spark 3.5 project is included in the buildextraJvmArgsfrom build.gradle into jmh.gradle to pass--add-opensflags needed on JDK 17+upload-artifact@v4+conflictsAI was used to help identify the root causes.
All changes were verified by running the benchmarks end-to-end.