Merged
Conversation
Iceberg switched to `at.yawk.lz4:lz4-java` group for security reasons, but it unintentionally introduced performance regression. https://github.com/yawkat/lz4-java/releases/tag/v1.10.4 > These changes attempt to fix the native performance regression in 1.9+. They should have no functional or security impact. See the benchmark reports in Celeborn and Spark projects - CELEBORN-2218 / apache/celeborn#3555 - SPARK-55803 / apache/spark#54585
singhpk234
approved these changes
Mar 5, 2026
Contributor
singhpk234
left a comment
singhpk234
left a comment
There was a problem hiding this comment.
LGTM, thanks @pan3793
for other reviewers plz ref : yawkat/lz4-java#30 for extent of regression
huaxingao
approved these changes
Mar 5, 2026
kevinjqliu
approved these changes
Mar 5, 2026
ebyhr
approved these changes
Mar 5, 2026
Contributor
|
Thanks @pan3793 for the PR! Thanks @singhpk234 @kevinjqliu @ebyhr for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Iceberg switched to
at.yawk.lz4:lz4-javafor security reasons, but it unintentionally introduced performance regression.https://github.com/yawkat/lz4-java/releases/tag/v1.10.4
See the benchmark reports in Celeborn and Spark projects