Spark: Cache ENTRIES scan in RemoveDanglingDeletesSparkAction to avoid duplicate manifest reads#15519
Open
hemanthboyina wants to merge 1 commit intoapache:mainfrom
Open
Spark: Cache ENTRIES scan in RemoveDanglingDeletesSparkAction to avoid duplicate manifest reads#15519hemanthboyina wants to merge 1 commit intoapache:mainfrom
hemanthboyina wants to merge 1 commit intoapache:mainfrom
Conversation
…d duplicate manifest reads
Contributor
|
@hemanthboyina I dont think we load the same manifests twice due to the manifest status is being pushed down to filter which manifest to scan, see more in #10203. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The findDanglingDeletes() method in RemoveDanglingDeletesSparkAction currently loads the ENTRIES
metadata table twice — once to compute minimum sequence numbers from data files, and once to find
delete file entries. Each load triggers a full scan of all manifest files. This change loads the
ENTRIES table once, caches the live entries, and filters into data and delete paths from the cached
result. The cache is properly released in a finally block. This halves the manifest I/O for tables
with many manifests.