Core: Replace Failsafe with Tasks #15613
Merged
singhpk234 merged 1 commit intoapache:mainfrom Mar 13, 2026
Merged
Conversation
singhpk234
changed the title
Replace the Failsafe library dependency in RESTTableScan.fetchPlanningResult() with Iceberg's built-in Tasks utility for retry/backoff, aligning with codebase conventions and removing the failsafe dependency from iceberg-core.
sfc-gh-prsingh
force-pushed
the
replace-failsafe-with-tasks-in-rest-table-scan
branch
from
36a4e7b to
a5b0229
Compare
rdblue
reviewed
Mar 13, 2026
| implementation libs.jackson.databind | ||
| implementation libs.caffeine | ||
| implementation libs.roaringbitmap | ||
| implementation libs.failsafe |
rdblue
reviewed
Mar 13, 2026
rdblue
approved these changes
Mar 13, 2026
Contributor
rdblue
left a comment
rdblue
left a comment
There was a problem hiding this comment.
Looks good! Thanks for fixing this, @singhpk234!
FYI @amogh-jahagirdar.
amogh-jahagirdar
approved these changes
Mar 13, 2026
Contributor
amogh-jahagirdar
left a comment
amogh-jahagirdar
left a comment
There was a problem hiding this comment.
Yeah I agree that in this case it is more minimal just to use Tasks! Thanks @singhpk234 for fixing this
Contributor
Author
|
Thanks @rdblue @amogh-jahagirdar for the review ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the Failsafe library dependency in RESTTableScan.fetchPlanningResult()
with Iceberg's built-in Tasks utility for retry/backoff,
aligning with codebase conventions and removing the failsafe dependency from iceberg-core.