Fix multi-topic routing to prevent writing all records to all tables#15639
Open
aryash45 wants to merge 1 commit intoapache:mainfrom
Open
Fix multi-topic routing to prevent writing all records to all tables#15639aryash45 wants to merge 1 commit intoapache:mainfrom
aryash45 wants to merge 1 commit intoapache:mainfrom
Conversation
When iceberg.tables.route-field is not set, records from all topics were being written to all tables if they shared the same id-columns name and similar schemas. This was due to the routing logic broadcasting to all tables instead of matching topics to table names. This change implements topic-based routing by: - Extracting the last dot-delimited segment from both topic and table names - Matching them case-insensitively - Only writing to matching tables - Falling back to broadcast only if no topic-to-table match is found This preserves backward compatibility while fixing the multi-topic routing issue reported in apache#15584. Changes: - SinkWriter.java: Added topic-based routing in routeRecordStatically() - Added lastSegment() helper method - TestSinkWriter.java: Added testTopicRoute(), testTopicRouteSecondTable(), and testTopicRouteFallbackBroadcast() test cases Closes apache#15584
Author
|
hey @nastra @huaxingao please review this pr and tell me if anything needs changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When iceberg.tables.route-field is not set, records from all topics were being written to all tables if they shared the same id-columns name and similar schemas. This was due to the routing logic broadcasting to all tables instead of matching topics to table names.
This change implements topic-based routing by:
This preserves backward compatibility while fixing the multi-topic routing issue reported in #15584.
Changes:
Questions For Maintainers
-Should unmatched topic fallback log a warning to alert users of potential misconfiguration?
Closes #15584