site: add back privacy plugin#15657
Conversation
|
There was a problem hiding this comment.
Pull request overview
Reintroduces the privacy plugin in the site’s MkDocs configuration (after the mkdocs-material bump in #15643) to improve GDPR compliance by preventing external asset usage, while avoiding the reported make build failure by excluding problematic bladepipe.com assets.
Changes:
- Add mkdocs-material
privacyplugin to the MkDocs plugin list. - Configure
assets_excludeto skip fetching assets under*bladepipe.com/*, preventing the build-timeFileNotFoundError.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| - monorepo | ||
| - privacy: | ||
| assets_exclude: | ||
| - '*bladepipe.com/*' |
There was a problem hiding this comment.
If we remove bladepipe.md in all previous releases, we probably don't need this exclusion.
There was a problem hiding this comment.
yea its caused by
iceberg/1.10.1/docs/bladepipe.md
Line 107 in 33c16e2
When
make build runs, it pulls it all historical versions
lets keep this workaround for now

Follow up to #15643, we should probably add back
privacyplugin for compliance with GDPRhttps://squidfunk.github.io/mkdocs-material/plugins/privacy/
make buildwas erroring withFixed by excluding
*bladepipe.com/*fromprivacyplugin. It tries to fetch assets an assert thats missing.