Skip to content

site: add back privacy plugin#15657

Merged
kevinjqliu merged 3 commits intoapache:mainfrom
kevinjqliu:kevinjqliu/add-back-privacy-plugin
Mar 17, 2026
Merged

site: add back privacy plugin#15657
kevinjqliu merged 3 commits intoapache:mainfrom
kevinjqliu:kevinjqliu/add-back-privacy-plugin

Conversation

@kevinjqliu
Copy link
Contributor

@kevinjqliu kevinjqliu commented Mar 16, 2026

Follow up to #15643, we should probably add back privacy plugin for compliance with GDPR
https://squidfunk.github.io/mkdocs-material/plugins/privacy/

make build was erroring with

FileNotFoundError: [Errno 2] No such file or directory: '/home/runner/work/iceberg/iceberg/site/.cache/plugin/privacy/assets/external/doc.bladepipe.com/assets/images/1-afd4d16b1739f59151ceb30d6189cfc4.png'

Fixed by excluding *bladepipe.com/* from privacy plugin. It tries to fetch assets an assert thats missing.

@kevinjqliu
Copy link
Contributor Author

FileNotFoundError: [Errno 2] No such file or directory: '/home/runner/work/iceberg/iceberg/site/.cache/plugin/privacy/assets/external/doc.bladepipe.com/assets/images/1-afd4d16b1739f59151ceb30d6189cfc4.png'
make: *** [Makefile:30: build] Error 1

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reintroduces the privacy plugin in the site’s MkDocs configuration (after the mkdocs-material bump in #15643) to improve GDPR compliance by preventing external asset usage, while avoiding the reported make build failure by excluding problematic bladepipe.com assets.

Changes:

  • Add mkdocs-material privacy plugin to the MkDocs plugin list.
  • Configure assets_exclude to skip fetching assets under *bladepipe.com/*, preventing the build-time FileNotFoundError.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

- monorepo
- privacy:
assets_exclude:
- '*bladepipe.com/*'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we remove bladepipe.md in all previous releases, we probably don't need this exclusion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea its caused by

![Iceberg structure configuration](https://doc.bladepipe.com/assets/images/2-e436c11d029481dc58c5a86d17a2fc7b.png)

When make build runs, it pulls it all historical versions

lets keep this workaround for now

we can try to remove bladepipe.md, its only in 2 versions:
Screenshot 2026-03-16 at 6 24 19 PM

@kevinjqliu kevinjqliu merged commit b99e12a into apache:main Mar 17, 2026
10 checks passed
@kevinjqliu kevinjqliu deleted the kevinjqliu/add-back-privacy-plugin branch March 17, 2026 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants