Spec: Change wording of 'custom' to 'non-default' for Geo type crs#15781
Open
szehon-ho wants to merge 1 commit intoapache:mainfrom
Open
Spec: Change wording of 'custom' to 'non-default' for Geo type crs#15781szehon-ho wants to merge 1 commit intoapache:mainfrom
szehon-ho wants to merge 1 commit intoapache:mainfrom
Conversation
github-actions
bot
added
the
Specification
Member
Author
|
@jiayuasu @paleolimbot @mkaravel @rdblue what do you guys think? |
Member
|
This makes sense to me! |
huaxingao
changed the title
mkaravel
approved these changes
Mar 26, 2026
huaxingao
approved these changes
Mar 27, 2026
jiayuasu
approved these changes
Mar 27, 2026
singhpk234
approved these changes
Mar 27, 2026
rdblue
approved these changes
Mar 27, 2026
Contributor
rdblue
left a comment
rdblue
left a comment
There was a problem hiding this comment.
Seems like a reasonable clarification to me. Should we also be clear that the list of types is not exhaustive?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wording 'custom' causes some confusion. It could be taken to mean a 'custom' CRS not defined in existing authorities. Whereas here, actually these are very common CRS's. In the geo domain, these are not 'custom'.
I think it's more clear to use the word 'non-default' here, as that's what was meant, especially as we just mention 'default' just above.