CI: Fix JMH benchmark workflows#15800
Merged
kevinjqliu merged 8 commits intoapache:mainfrom Mar 28, 2026
Merged
Conversation
kevinjqliu
commented
Mar 27, 2026
site/docs/benchmarks.md
Outdated
| A benchmark that evaluates the performance of writing nested Parquet data using Iceberg and the built-in file source in Spark. To run this benchmark for either spark-2 or spark-3: | ||
|
|
||
| `./gradlew :iceberg-spark:iceberg-spark-3.5_2.12:jmh -PjmhIncludeRegex=IcebergSourceNestedListParquetDataWriteBenchmark -PjmhOutputPath=benchmark/iceberg-source-nested-list-parquet-data-write-benchmark-result.txt` | ||
| `./gradlew -DsparkVersions=3.5 -DscalaVersion=2.12 :iceberg-spark:iceberg-spark-3.5_2.12:jmh -PjmhIncludeRegex=IcebergSourceNestedListParquetDataWriteBenchmark -PjmhOutputPath=benchmark/iceberg-source-nested-list-parquet-data-write-benchmark-result.txt` |
Contributor
Author
There was a problem hiding this comment.
ran and validated this locally
huaxingao
reviewed
Mar 27, 2026
huaxingao
reviewed
Mar 27, 2026
ebyhr
reviewed
Mar 27, 2026
|
|
||
| - name: Run Benchmark | ||
| run: ./gradlew :iceberg-spark:${{ matrix.spark_version }}:jmh -PjmhIncludeRegex=${{ matrix.benchmark }} -PjmhOutputPath=benchmark/${{ matrix.benchmark }}.txt -PjmhJsonOutputPath=benchmark/${{ matrix.benchmark }}.json | ||
| run: ./gradlew -DsparkVersions=${{ matrix.spark }} -DscalaVersion=${{ matrix.scala }} :iceberg-spark:iceberg-spark-${{ matrix.spark }}_${{ matrix.scala }}:jmh -PjmhIncludeRegex=${{ matrix.benchmark }} -PjmhOutputPath=benchmark/${{ matrix.benchmark }}.txt -PjmhJsonOutputPath=benchmark/${{ matrix.benchmark }}.json |
Member
There was a problem hiding this comment.
I sent a similar PR #15729 a few days ago and noticed the actions/upload-artifact below fails with the conflicted artifact name. My PR added another step to change the artifact name. Does this PR work without such changes?
I'll close my PR. Please feel to copy the change if needed :)
Member
There was a problem hiding this comment.
I've tested this PR at #15802. The job failed with:
Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run
Contributor
Author
There was a problem hiding this comment.
thanks! i ran into this https://github.com/apache/iceberg/actions/runs/23669409378/job/68959473079
cherry picked your commit and fix it up
huaxingao
approved these changes
Mar 28, 2026
Contributor
huaxingao
left a comment
huaxingao
left a comment
There was a problem hiding this comment.
LGTM. Thanks @kevinjqliu
manuzhang
pushed a commit
to manuzhang/iceberg
that referenced
this pull request
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix both
jmh-benchmarks.ymlandrecurring-jmh-benchmarks.ymlgithub workflows, and updatesite/docs/benchmarks.mdThe JMH benchmark workflows were broken because:
-DsparkVersionsiceberg-spark-3.5) missing the Scala suffixChanges
jmh-benchmarks.ymlspark_versioninput into separatespark_version(default3.5) andscala_version(default2.12)-DsparkVersionsand-DscalaVersionto Gradle to register the correct Spark projectshow-matrixto readspark_versionfromgithub.event.inputsinstead of non-existent job outputrecurring-jmh-benchmarks.ymlsparkandscalamatrix parameters with-DsparkVersionsand-DscalaVersionrepository/refcheckout params (schedule trigger has no inputs)workflow_dispatchtrigger for manual runssite/docs/benchmarks.md-DsparkVersions=3.5 -DscalaVersion=2.12to all local benchmark commandsTesting
Tested on forked repo w/ multiple benchmarks
https://github.com/kevinjqliu/iceberg/actions/runs/23672440749