Sink connector crashes on timestamps with fractional seconds and colon-separated UTC offset (Fixes #15838)#15839
Open
soumyajit-sahu wants to merge 2 commits intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ensureTimestampFormat normalizes colon-separated offsets (+00:00 → +0000) so that the internal OFFSET_TIMESTAMP_FORMAT formatter (which uses appendOffset("+HHmm", "Z")) can parse them. However, it assumed the timezone sign is always at character index 19 — which is only true when there are no fractional seconds.
When the normalization was skipped, OFFSET_TIMESTAMP_FORMAT failed to parse the string (colon still present). The fallback LocalDateTime.parse with ISO_LOCAL_DATE_TIME then also failed because the +00:00 suffix was still attached. The combined failure produced a connector task crash.
This change replaces the hardcoded index-19 check with a forward scan starting at index 19, dynamically locating the timezone sign regardless of how many fractional-second digits precede it. The colon is then stripped at the correct position.
Closes #15838