Spark (3.4,3.5,4.0) : Include snapshotId and branch in SparkTable equals and hashCode#15840
Open
bharos wants to merge 1 commit intoapache:mainfrom
Open
Spark (3.4,3.5,4.0) : Include snapshotId and branch in SparkTable equals and hashCode#15840bharos wants to merge 1 commit intoapache:mainfrom
bharos wants to merge 1 commit intoapache:mainfrom
Conversation
… and hashCode SparkTable.equals() and hashCode() only compared the table name, causing Spark to return cached query results for time-travel and branch queries. When a user reads from branch 'main' and then branch 'audit', Spark's cache considered them equal and returned stale data from 'main'. Include snapshotId and branch fields in equals() and hashCode() so that Spark correctly distinguishes tables loaded at different snapshots or branches. This matches the fix already applied in Spark 4.1 (main). Closes apache#15741
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SparkTable.equals() and hashCode() only compared the table name, causing Spark to return cached query results for time-travel and branch queries. When a user reads from branch 'main' and then branch 'audit', Spark's cache considered them equal and returned stale data from 'main'.
Include snapshotId and branch fields in equals() and hashCode() so that Spark correctly distinguishes tables loaded at different snapshots or branches. This matches the fix already applied in Spark 4.1 (current main).
Closes #15741