Parquet: Fix ParquetWriteAdapter NPE when accessing length/splitOffsets after close#15879
Open
jackylee-ch wants to merge 1 commit intoapache:mainfrom
Open
Parquet: Fix ParquetWriteAdapter NPE when accessing length/splitOffsets after close#15879jackylee-ch wants to merge 1 commit intoapache:mainfrom
jackylee-ch wants to merge 1 commit intoapache:mainfrom
Conversation
…ts after close ParquetWriteAdapter.close() nullifies the internal Hadoop ParquetWriter but length() and splitOffsets() still dereference it, causing NPE when called after close (e.g. from DataWriter.close()). Fix by caching data size before close and reusing the already-cached footer for splitOffsets(). This restores FileAppender post-close contract compliance. Also removes the pre-close length() workaround in ParquetWritingTestUtils that was needed because of this bug. Fixes apache#14310
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ParquetWriteAdapter.length()andsplitOffsets()when called afterclose()by caching data size and reusing cached footer before nullifying the internal writerFileAppenderpost-close contract for the deprecated adapterlength()workaround inParquetWritingTestUtilsthat was needed because of this bugFixes #14310
Test Plan
TestParquetWriteAdapter.postCloseAccessors— verifieslength(),metrics(),splitOffsets()work after closeTestParquetWriteAdapter.dataWriterCloseWithDeprecatedAdapter— end-to-endDataWriter.close()path:iceberg-parquet:testsuite — 642 tests pass, 0 failures