Core, AWS, Spark: Implement storage-refresh-token support#15899
Open
manisin wants to merge 3 commits intoapache:mainfrom
Open
Core, AWS, Spark: Implement storage-refresh-token support#15899manisin wants to merge 3 commits intoapache:mainfrom
manisin wants to merge 3 commits intoapache:mainfrom
Conversation
stevenzwu
changed the title
stevenzwu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements client-side support for the
storage-refresh-tokencredential refresh flow specified in #15280.Core changes:
StorageCredential/ImmutableStorageCredential: AddstorageRefreshToken()accessor and 3-argumentcreate()factory methodCredential(REST model): AddstorageRefreshTokenfield with Immutables supportCredentialParser: Serialize/deserializestorage-refresh-tokenin JSONRESTSessionCatalog: Propagate refresh token through both theSupportsStorageCredentialsandCatalogUtil.loadFileIOcredential pathsRESTCatalogProperties: AddREST_STORAGE_REFRESH_TOKENconstantAWS changes:
S3FileIO: PassstorageRefreshTokeninto per-prefix client properties and use the 3-argStorageCredential.create()during credential refreshVendedCredentialsProvider: SendstorageRefreshTokenas a query parameter on credential fetch requests (mutually exclusive withplanId)Tests:
TestStorageCredentialRefresh: End-to-end credential refresh flow against an embedded REST catalog (core)TestStagedTableCredentialRefreshE2E: Spark integration test for staged table credential refreshTestCredentialParser,TestLoadCredentialsResponseParser,TestStorageCredential,TestVendedCredentialsProvider,TestS3FileIOCredentialRefreshDepends on: #15280