Closed
Conversation
Contributor
Author
|
CC: @rdblue |
Contributor
|
Hi @nssalian, I saw CI failed when I merged a PR. I opened #15937 which combines the runtime-deps fix with a fix for the zizmor ref-version-mismatch failure (bumping actions/upload-artifact from 7.0.0 to 7.0.1). Both issues need to land together for CI to pass on main. Sorry I just saw your PR. I will add you as the co-author. |
Contributor
Author
|
Fixed in #15937 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
runtime-deps.txtbaseline added in #15860 was generated against a stale branch, before the netty bump (#15891) and other dependency changes landed onmain. This causescheckRuntimeDepsto fail on every PR.I wonder if there is a better way to do this and keep this updated since the versions could get bumped outside of a contributor's purview. Adding this fix for now.
Changes
Regenerated the baseline with
./gradlew :iceberg-spark:iceberg-spark-runtime-4.1_2.13:generateRuntimeDeps --refresh-dependencies.Test plan
./gradlew :iceberg-spark:iceberg-spark-runtime-4.1_2.13:checkRuntimeDepslocally