AWS: Apply service configurations to S3AsyncClient#16030
Open
yadavay-amzn wants to merge 1 commit into
Open
Conversation
Apply S3FileIOProperties.applyServiceConfigurations() to the S3AsyncClient builder, matching the existing sync S3Client configuration. Without this, settings like s3.path-style-access and s3.dualstack-enabled silently do not apply to async operations.
yadavay-amzn
changed the title
Contributor
Author
|
@jackye1995 @nastra Could you take a look when you get a chance? This fixes a bug where S3 service configurations (path-style-access, dualstack, acceleration, use-arn-region) are not applied to the async client. CI is green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug where
DefaultAwsClientFactoryappliesS3FileIOProperties.applyServiceConfigurations()to the synchronousS3Clientbut not to theS3AsyncClient. This means settings likes3.path-style-access,s3.dualstack-enabled,s3.accelerate-enabled, ands3.use-arn-region-enabledsilently do not take effect for async S3 operations.Changes
S3FileIOProperties.applyServiceConfigurations()fromS3ClientBuildertoS3BaseClientBuilder<T, ?>so it accepts both sync and async builders.applyServiceConfigurationscall to theS3AsyncClient.builder()path inDefaultAwsClientFactory.s3Async().testApplyS3AsyncServiceConfigurationsverifying that path-style access, ARN region, and acceleration settings are correctly applied to the async client builder.Closes #14575