Skip to content

AWS Bundle: Exclude logging dependencies#16105

Merged
amogh-jahagirdar merged 2 commits intoapache:mainfrom
rdblue:license-fix-remove-log4j
Apr 27, 2026
Merged

AWS Bundle: Exclude logging dependencies#16105
amogh-jahagirdar merged 2 commits intoapache:mainfrom
rdblue:license-fix-remove-log4j

Conversation

@rdblue
Copy link
Copy Markdown
Contributor

@rdblue rdblue commented Apr 24, 2026

This removes log4j from iceberg-aws-bundle dependencies.

The classes were already removed from the runtime Jar by an exclusion in the shadowJar configuration, but excluding them when the Jar is created leaves the dependency listed in runtime-deps.txt, which is how I found this. The solution is to add an exclusion from the implementation configuration so that the deps match.

This produces the following dependency changes to the runtimeClasspath configuration:

10d10
< +--- org.slf4j:slf4j-api:2.0.17
66,67c66
< |    |    |    |    |    |    |    |    +--- software.amazon.awssdk:annotations:2.42.33
< |    |    |    |    |    |    |    |    \--- org.slf4j:slf4j-api:1.7.36 -> 2.0.17
---
> |    |    |    |    |    |    |    |    \--- software.amazon.awssdk:annotations:2.42.33
110d108
< |    |    |    |    |    |    +--- org.slf4j:slf4j-api:1.7.36 -> 2.0.17
122,126c120,123
< |    |    |    |    |    |    +--- software.amazon.awssdk:json-utils:2.42.33
< |    |    |    |    |    |    |    +--- software.amazon.awssdk:utils:2.42.33 (*)
< |    |    |    |    |    |    |    +--- software.amazon.awssdk:annotations:2.42.33
< |    |    |    |    |    |    |    \--- software.amazon.awssdk:third-party-jackson-core:2.42.33
< |    |    |    |    |    |    \--- org.slf4j:slf4j-api:1.7.36 -> 2.0.17
---
> |    |    |    |    |    |    \--- software.amazon.awssdk:json-utils:2.42.33
> |    |    |    |    |    |         +--- software.amazon.awssdk:utils:2.42.33 (*)
> |    |    |    |    |    |         +--- software.amazon.awssdk:annotations:2.42.33
> |    |    |    |    |    |         \--- software.amazon.awssdk:third-party-jackson-core:2.42.33
255,256c252
< |    |         +--- org.reactivestreams:reactive-streams:1.0.4
< |    |         \--- org.slf4j:slf4j-api:1.7.36 -> 2.0.17
---
> |    |         \--- org.reactivestreams:reactive-streams:1.0.4
262,266d257
< |    +--- org.apache.logging.log4j:log4j-slf4j-impl:2.20.0
< |    |    +--- org.apache.logging.log4j:log4j-api:2.20.0
< |    |    +--- org.slf4j:slf4j-api:1.7.25 -> 2.0.17
< |    |    \--- org.apache.logging.log4j:log4j-core:2.20.0
< |    |         \--- org.apache.logging.log4j:log4j-api:2.20.0

@rdblue rdblue force-pushed the license-fix-remove-log4j branch from 620f87c to 1cf45f6 Compare April 24, 2026 22:19
Copy link
Copy Markdown
Contributor

@singhpk234 singhpk234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @rdblue !

@amogh-jahagirdar
Copy link
Copy Markdown
Contributor

Thanks @rdblue! @singhpk234 @huaxingao for reviewing

@amogh-jahagirdar amogh-jahagirdar merged commit afb7519 into apache:main Apr 27, 2026
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants