AWS Bundle: Exclude logging dependencies#16105
Merged
amogh-jahagirdar merged 2 commits intoapache:mainfrom Apr 27, 2026
Merged
Conversation
620f87c to
1cf45f6
Compare
singhpk234
approved these changes
Apr 24, 2026
Contributor
singhpk234
left a comment
There was a problem hiding this comment.
LGTM, thanks @rdblue !
huaxingao
approved these changes
Apr 25, 2026
amogh-jahagirdar
approved these changes
Apr 27, 2026
Contributor
|
Thanks @rdblue! @singhpk234 @huaxingao for reviewing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes log4j from iceberg-aws-bundle dependencies.
The classes were already removed from the runtime Jar by an exclusion in the
shadowJarconfiguration, but excluding them when the Jar is created leaves the dependency listed in runtime-deps.txt, which is how I found this. The solution is to add an exclusion from theimplementationconfiguration so that the deps match.This produces the following dependency changes to the
runtimeClasspathconfiguration: