Skip to content

Spec: Fix reserved field ID limit#16111

Open
dannycjones wants to merge 1 commit into
apache:mainfrom
dannycjones:patch-1
Open

Spec: Fix reserved field ID limit#16111
dannycjones wants to merge 1 commit into
apache:mainfrom
dannycjones:patch-1

Conversation

@dannycjones
Copy link
Copy Markdown

According to the Java implementation, this requirement is inclusive or "greater than or equal" to this value.

public static int statsFieldIdForField(int fieldId) {
return fieldId >= RESERVED_FIELD_IDS_START
? statsFieldIdForReservedField(fieldId)
: statsFieldIdForDataField(fieldId);
}

I am proposing to update the spec to clarify this. This appears to change the spec itself though, so I'm open to looking instead at changing this in the Java implementation to accommodate the difference with the spec.

@github-actions github-actions Bot added the Specification Issues that may introduce spec changes. label Apr 25, 2026
@dannycjones dannycjones changed the title Update reserved field ID limit in spec.md Spec: Fix reserved field ID limit Apr 25, 2026
@github-actions
Copy link
Copy Markdown

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.

@github-actions github-actions Bot added the stale label May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Specification Issues that may introduce spec changes. stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant