Hive: add HiveCatalog(Configuration, Map<String, String>) convenience constructor#16135
Open
1fanwang wants to merge 1 commit intoapache:mainfrom
Open
Hive: add HiveCatalog(Configuration, Map<String, String>) convenience constructor#161351fanwang wants to merge 1 commit intoapache:mainfrom
1fanwang wants to merge 1 commit intoapache:mainfrom
Conversation
… constructor Closes apache#16134
deniskuzZ
reviewed
Apr 28, 2026
| */ | ||
| public HiveCatalog(Configuration conf, Map<String, String> properties) { | ||
| setConf(conf); | ||
| initialize("hive", properties); |
Member
There was a problem hiding this comment.
since we provide a constructor now, should we change setConf and initialize to private and avoid confusion with those APIs?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16134.
HiveCatalog.initialize(name, properties)reads URI/warehouse from the property map and HMS/Hadoop settings from theConfiguration. Callers that have both populated currently need the two-stepsetConf(conf); initialize(name, properties)dance.This adds a convenience constructor mirroring
HadoopCatalog(Configuration, String), accepting a property map sinceHiveCatalogreads more than one key:testConstructorWithConfAndPropertiesinTestHiveCatalogcovers the property-to-conf propagation and verifies caller-provided Configuration entries are preserved.Surfaced in apache/hive#6454.