Add tests for nested field drop/re-add ID behavior in schema evolution#16145
Draft
longvu-db wants to merge 2 commits into
Draft
Add tests for nested field drop/re-add ID behavior in schema evolution#16145longvu-db wants to merge 2 commits into
longvu-db wants to merge 2 commits into
Conversation
Add 6 tests to TestSchemaUpdate verifying that parent and sibling field IDs are preserved when nested fields are dropped, re-added, or expanded in structs, lists, and maps: - Drop+re-add nested struct field with different name - Drop+re-add nested field with same name (ID never recycled) - Drop+re-add field in struct nested in list - Drop+re-add field in struct nested in map value - Drop-only nested field (parent and sibling IDs preserved) - Add-only nested field (existing IDs preserved, fresh ID assigned) Co-authored-by: Isaac
Co-authored-by: Isaac
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestSchemaUpdateverifying that parent and sibling field IDs are preserved when nested fields are dropped, re-added, or expanded in structs, lists, and mapsmaxColumnIdincrements monotonicallyTest scenarios
Generated-by: Claude Opus 4.6