Kafka Connect: Prevent zombie coordinator during rebalance#16156
Open
kumarpritam863 wants to merge 26 commits into
Open
Kafka Connect: Prevent zombie coordinator during rebalance#16156kumarpritam863 wants to merge 26 commits into
kumarpritam863 wants to merge 26 commits into
Conversation
Contributor
Author
|
@danielcweeks can you please review. |
Contributor
Author
|
@bryanck can you please review. |
Contributor
Author
|
@danielcweeks can you please take a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
During a Kafka Connect rebalance, CommitterImpl.close() calls stopCoordinator() which sets the termination flag and shuts down the executor, but returns before the CoordinatorThread has fully exited its run() loop and closed its Kafka producer/consumer/admin clients. If open() is called on the new leader task before the old thread finishes, two coordinators can briefly run simultaneously:
While Iceberg's optimistic concurrency (CAS) and the SnapshotAncestryValidator prevent corrupt commits, the race window can cause spurious CommitFailedException errors, partial control topic partition visibility, and unnecessary commit retries.
Fix