Core: Add partition to TrackedFile#16253
Merged
Merged
Conversation
nastra
force-pushed
the
v4-add-partition-to-trackedfile
branch
from
5a97adf to
b10fb2e
Compare
nastra
commented
May 8, 2026
|
|
||
| List<FieldStats<?>> fieldStatsList = | ||
| ImmutableList.of( | ||
| (FieldStats<?>) |
Contributor
Author
There was a problem hiding this comment.
this and the suppression were unnecessary
nastra
force-pushed
the
v4-add-partition-to-trackedfile
branch
from
b10fb2e to
6f21db2
Compare
anoopj
approved these changes
May 8, 2026
| FileContent.DATA, | ||
| "s3://bucket/data/file.parquet", | ||
| FileFormat.PARQUET, | ||
| new PartitionData(Types.StructType.of()), |
Contributor
There was a problem hiding this comment.
Optional: Would it make sense to test with an actual partition value?
nastra
force-pushed
the
v4-add-partition-to-trackedfile
branch
from
6f21db2 to
eaf1f72
Compare
amogh-jahagirdar
approved these changes
May 12, 2026
Contributor
amogh-jahagirdar
left a comment
amogh-jahagirdar
left a comment
There was a problem hiding this comment.
Overall looks good to me thanks @nastra just a minor comment
| private long recordCount = -1L; | ||
| private long fileSizeInBytes = -1L; | ||
| private Integer specId = null; | ||
| private PartitionData partitionData = null; |
Contributor
There was a problem hiding this comment.
Minor: Would it simplify some of the below code if we just set this to EMPTY_PARTITION_DATA?
nastra
force-pushed
the
v4-add-partition-to-trackedfile
branch
from
eaf1f72 to
9f08873
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the v1-v3
DataFile.partition(field ID102) to the v4TrackedFile, so partition data continues to be tracked per-file in v4 manifests