Core: Use toOptional and onlyElement methods in MoreCollectors#16254
Open
ebyhr wants to merge 1 commit into
Open
Core: Use toOptional and onlyElement methods in MoreCollectors#16254ebyhr wants to merge 1 commit into
ebyhr wants to merge 1 commit into
Conversation
singhpk234
reviewed
May 8, 2026
Contributor
singhpk234
left a comment
There was a problem hiding this comment.
Are there use case for this for non test scenarios ?
On an orthogonal note it seems like the tests are just fine without this
cf44360 to
3c8d443
Compare
Member
Author
|
@singhpk234 Yes, the same pattern persists even in non-test code. I've made additional modifications, and there are actually more places where this pattern occurs. |
3c8d443 to
91ae9b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing
findFirstsilently hides multiple matching elements.This PR replaces it with Guava MoreCollectors:
onlyElement method:
toOptional method:
I only updated a few places to demonstrate how to use them.