Spark: Disable min/max aggregation push down for binary#16328
Merged
huaxingao merged 1 commit intoMay 14, 2026
Merged
Conversation
Co-authored-by: Timothy Meehan <tim@timdmeehan.com>
Contributor
Author
|
Hi @huaxingao, thanks for review #16320. This PR is another fix for min/max aggregation push down, applying the same constraints to binary columns as are already applied to string columns. Since Iceberg may truncate min/max statistics for binary columns in Parquet files. Please take a look when you have a chance, thanks a lot! |
huaxingao
changed the title
huaxingao
approved these changes
May 14, 2026
Contributor
|
Thanks @hantangwangd for the PR! |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For min/max aggregation push down, binary has the same limitations as string. Iceberg may truncate min/max statistics for binary columns in Parquet files. Since min/max push down is already disabled for string, this PR extends the same behavior to binary columns to avoid potential incorrect results. Refer to the test case in this PR for details.