Docs: add more to 1.10.2 release notes#16410
Conversation
|
cc @manuzhang thanks for pointing this out |
| * GCP | ||
| - Fix LICENSE and NOTICE files ([\#16244](https://github.com/apache/iceberg/pull/16244)) | ||
| * Open API | ||
| - Stop publishing the Open API runtime Jar ([\#16188](https://github.com/apache/iceberg/pull/16188)) |
There was a problem hiding this comment.
made this more explicit instead of the PR title (Open API: Backport 1.10 Remove runtime Jar from build and deploy)
There was a problem hiding this comment.
Do we need to mention what's the side effect of this change?
There was a problem hiding this comment.
im not sure i understand; i thought the side effect is that we stop publishing the open api runtime jar.
There was a problem hiding this comment.
It changes the downstream dependencies if a project has previously depended on iceberg-open-api as I've shown in manuzhang/iceberg-examples#40
There was a problem hiding this comment.
could you try again with the released 1.10.2?
i think maybe the RC version had the iceberg-open-api jar perhaps, i cant verify because https://repository.apache.org/content/repositories/orgapacheiceberg-1281/ is gone
i do see that the iceberg-open-api jar is no longer in 1.10.2 https://repo1.maven.org/maven2/org/apache/iceberg/iceberg-open-api/1.10.2/ (but is in 1.10.1 https://repo1.maven.org/maven2/org/apache/iceberg/iceberg-open-api/1.10.1/)
There was a problem hiding this comment.
I'm okay either way here, on the one hand to me, I think this statement is enough but if it's helpful to include a note on what other dependencies need to be pulled in to achieve the same "things" that people would achieve when consuming the open API jar before then maybe we mention that too.
There was a problem hiding this comment.
I think release notes is the most effective channel to communicate the change.
There was a problem hiding this comment.
oh i see. i was under the assumption that we will fix forward the open-api jar. but i think we're only doing that for the 1.11.x release.
so for 1.10.2 here, i think its worth explaining the change 👍 thanks!
LMK if you have any suggestions for wording here.
There was a problem hiding this comment.
Even if we are going to fix it in 1.11.x, I believe it's worth calling out in the 1.11.0 release notes as well.
There was a problem hiding this comment.
added some context, verified by running the rest service locally
- Stop publishing the Open API runtime Jar due to license compliance issues ([\#16188](https://github.com/apache/iceberg/pull/16188)). Users who depended on the shadow JAR must now use the `test-fixtures` classifier and explicitly add `iceberg-core`, `iceberg-core:tests`, `jetty-server`, `jetty-servlet`, `sqlite-jdbc`, and `hadoop-common`.
| * GCP | ||
| - Fix LICENSE and NOTICE files ([\#16244](https://github.com/apache/iceberg/pull/16244)) | ||
| * Open API | ||
| - Stop publishing the Open API runtime Jar ([\#16188](https://github.com/apache/iceberg/pull/16188)) |
There was a problem hiding this comment.
I'm okay either way here, on the one hand to me, I think this statement is enough but if it's helpful to include a note on what other dependencies need to be pulled in to achieve the same "things" that people would achieve when consuming the open API jar before then maybe we mention that too.
3 participants
Context: #16406 (comment)
Include Open API jar changes to the 1.10.2 release notes
Edits made by agent based on https://github.com/apache/iceberg/releases/tag/apache-iceberg-1.10.2