Flink: Add FlinkFileSystemFileIO delegating to Flink's FileSystem#16411
Open
wombatu-kun wants to merge 1 commit into
Open
Flink: Add FlinkFileSystemFileIO delegating to Flink's FileSystem#16411wombatu-kun wants to merge 1 commit into
wombatu-kun wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Resolves #15352.
Flink ships pluggable FileSystem implementations (S3, HDFS, GCS, ...) that a Flink job already configures once for checkpoints and savepoints, including delegation-token and plugin-based authentication. Until now an Iceberg-on-Flink user had to separately re-configure Iceberg's FileIO for the same storage. FlinkFileSystemFileIO is a FileIO that discovers and delegates to Flink's FileSystem, removing the duplicate configuration and inheriting Flink FileSystem features such as delegation tokens (only the JobManager authenticates with Kerberos; TaskManagers reuse the token).
It is opt-in via the catalog's io-impl property (CatalogProperties.FILE_IO_IMPL) and must not be set through table properties, since other engines cannot use Flink's FileSystem. There are no core/api changes, so core stays engine-agnostic.
This revives #10151 by @pvary, which was closed only by the stale bot for inactivity, and ports it to all currently supported Flink lines (1.20, 2.0, 2.1) with a few modernizations:
Tests
TestFlinkFileSystemFileIO (added for v1.20, v2.0, v2.1): list-prefix at scale, file existence, prefix delete, bulk delete + bulk-delete error handling, read/write roundtrip, and Flink Kryo + Java serialization. All 8 tests pass on each of the three Flink trees; spotlessApply and checkstyle (main + test) pass on all three.
Closes #15352