Build: Replace deprecated Groovy space-assignment property syntax in build scripts#16579
Open
wombatu-kun wants to merge 1 commit into
Open
Build: Replace deprecated Groovy space-assignment property syntax in build scripts#16579wombatu-kun wants to merge 1 commit into
wombatu-kun wants to merge 1 commit into
Conversation
…build scripts Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15976
Summary
Gradle deprecated the Groovy DSL "space-assignment" syntax for setting properties (e.g.
exceptionFormat "full") in favor of explicit assignment (exceptionFormat = "full"). It currently emitsProperties should be assigned using the 'propName = value' syntax …warnings and is scheduled for removal in Gradle 10. This migrates the remaining space-assignment usages across the build scripts so the build is quiet under--warning-mode alland ready for the eventual Gradle upgrade — the repository was already mostly migrated, and this completes it.Issue: #15976
What changed
Converted every remaining space-assignment property setter to
name = value(22 occurrences across 13 build scripts), preserving the existing quote style:exceptionFormat = "full"andmaxHeapSize = '…'in test / test-logging config (build.gradle,mr/build.gradle,spark/v3.5|v4.0|v4.1/build.gradle).zip64 = truein everyshadowJar { }block (build.gradle×2, theaws-/azure-/gcp-bundlebuilds, and the Spark and Flink runtime bundles).group = 'build'on thesourceJar/javadocJartasks andusername =/password =in the Mavencredentials { }block (deploy.gradle).destinationDir = …on theaggregateJavadoctask (tasks.gradle).Genuine method calls that merely resemble the pattern were intentionally left unchanged — e.g.
events "passed", "failed",systemProperty 'k', v,source javadocTasks.source, andconfigurations = [...](already correct). Unrelated deprecation categories (e.g.JavaPluginConventionfrom plugins, reserved configuration names) are out of scope for this issue.Tests
This is a build-script syntax migration with no runtime behavior change, so no unit tests apply. Verified by
./gradlew help --warning-mode all -DallModules=true— configures every Spark/Flink/Kafka/Scala module with BUILD SUCCESSFUL and zeropropName = valuewarnings remaining (a clean configure also proves each conversion targets a real settable property) — and by./gradlew :iceberg-core:test --tests "org.apache.iceberg.TestTableMetadata.testJsonConversion" --warning-mode all, confirming the convertedtest/testLoggingconfig still runs at execution time.