OpenAPI: Require at least one level in CatalogObjectIdentifier#16587
Closed
stevenzwu wants to merge 2 commits into
Closed
OpenAPI: Require at least one level in CatalogObjectIdentifier#16587stevenzwu wants to merge 2 commits into
stevenzwu wants to merge 2 commits into
Conversation
Add minItems: 1 to the CatalogObjectIdentifier schema. The Java implementation rejects an empty levels array; the spec should match so that clients and other server implementations are required to produce valid identifiers. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
3 tasks
nastra
approved these changes
May 28, 2026
stevenzwu
commented
May 28, 2026
| type: array | ||
| items: | ||
| type: string | ||
| minItems: 1 |
Contributor
Author
There was a problem hiding this comment.
link @c-thiel 's comment in the Java impl PR: #16160 (comment)
Contributor
Author
|
close this PR per the feedback from this thread. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
minItems: 1to theCatalogObjectIdentifierschema so the spec matches the Java implementation (CatalogObjectIdentifier.of), which rejects an empty levels array.