Core: Fix thread conflict when deleting duplicate files in manifest#16686
Open
HuaHuaY wants to merge 1 commit into
Open
Core: Fix thread conflict when deleting duplicate files in manifest#16686HuaHuaY wants to merge 1 commit into
HuaHuaY wants to merge 1 commit into
Conversation
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deleteFilesandduplicateDeleteCountare not thread-safe and they are modified concurrently infilterManifests. In addition,duplicateDeleteCountwill be counted repeatedly during the retry process after a commit failure.Add two tests:
deleteDuplicateFilesWithinMultipleManifestsensures that the count of duplicate files is accurate under concurrent conditions.deleteDuplicateFilesWithConcurrentDeleteRetryensures that retrying is not affected by previous unsuccessful commits.