Docs: Fix non-existent SortOrderBuilder method in evolution.md example#17085
Open
thswlsqls wants to merge 1 commit into
Open
Docs: Fix non-existent SortOrderBuilder method in evolution.md example#17085thswlsqls wants to merge 1 commit into
thswlsqls wants to merge 1 commit into
Conversation
The replaceSortOrder example called .dec(...) and used NullOrder.NULL_FIRST, neither of which exists in the API (SortOrderBuilder only has desc(...), and NullOrder's constant is NULLS_FIRST). The example does not compile as written. Generated-by: Claude Code
ebyhr
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17082
Summary
replaceSortOrderexample called.dec("category", NullOrder.NULL_FIRST); neitherdec(...)norNullOrder.NULL_FIRSTexist, so the example fails to compile..desc("category", NullOrder.NULLS_FIRST), matching the actualSortOrderBuilder/NullOrderAPI.NullOrder.NULLS_LAST), confirming this was a typo rather than a different intended API.Testing done
api/src/main/java/org/apache/iceberg/SortOrderBuilder.java(descmethods) andapi/src/main/java/org/apache/iceberg/NullOrder.java(NULLS_FIRST/NULLS_LASTconstants).