Skip to content

Comments

Docs: add documentation related to dynamic class loading#1737

Merged
rdblue merged 1 commit intoapache:masterfrom
jackye1995:dynamic-loader-doc
Nov 6, 2020
Merged

Docs: add documentation related to dynamic class loading#1737
rdblue merged 1 commit intoapache:masterfrom
jackye1995:dynamic-loader-doc

Conversation

@jackye1995
Copy link
Contributor

  • added new sections in custom catalog about implementing custom FileIO and LocationProvider, with some more details around how to load the custom classes.
  • added a new section in Configuration about catalog properties
  • added a new section in Spark about loading a custom catalog
  • added a new section in Flink about creating a custom catalog

@github-actions github-actions bot added the docs label Nov 6, 2020

Example:
```java
public class CustomFileIO implements FileIO {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't really needed for a custom catalog, and it is an option for the built-in catalogs. I think maybe we should move this to a doc on customizing tables, instead of here. Or, maybe just make it more clear that this isn't required. I think it is somewhat common for people to want to customize catalogs, and I don't want to make it seem like it is harder than it already is.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I think this is fine. We may want to clarify some of the wording, but I think this page is turning into general docs for customizing tables.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, maybe a more generic title like Customization would make more sense now.

@rdblue
Copy link
Contributor

rdblue commented Nov 6, 2020

Because this only changes docs, I think the test failure is unrelated. I'll merge this.

@rdblue rdblue merged commit 9af545e into apache:master Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants