Skip to content

Flink : exclude large data file when do the rewrite action#1762

Closed
zhangjun0x01 wants to merge 2 commits intoapache:masterfrom
zhangjun0x01:RemoveLargeDatafile
Closed

Flink : exclude large data file when do the rewrite action#1762
zhangjun0x01 wants to merge 2 commits intoapache:masterfrom
zhangjun0x01:RemoveLargeDatafile

Conversation

@zhangjun0x01
Copy link
Contributor

@zhangjun0x01 zhangjun0x01 commented Nov 13, 2020

in the current RewriteDataFilesAction, we should add a judge, if the filesize of datafile > targetSizeInBytes, it will not be rewrited

@HeartSaVioR
Copy link
Contributor

Probably better to use the word exclude, as remove may confuse to delete file which we just don't account for rewriting.

@zhangjun0x01 zhangjun0x01 changed the title Remove Large Data file when do the rewrite action exclude large data file when do the rewrite action Nov 17, 2020
@zhangjun0x01
Copy link
Contributor Author

Probably better to use the word exclude, as remove may confuse to delete file which we just don't account for rewriting.

yes,I update it

@zhangjun0x01 zhangjun0x01 changed the title exclude large data file when do the rewrite action Flink : exclude large data file when do the rewrite action Dec 31, 2020
@zhangjun0x01
Copy link
Contributor Author

@openinx I think this is also an optimization for RewriteDataFilesAction ,do you think it is necessary to add to 0.11.0 Release milestone ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments