Change ManifestList to an immutable list from linked list#1814
Closed
johnclara wants to merge 1 commit intoapache:masterfrom
Closed
Change ManifestList to an immutable list from linked list#1814johnclara wants to merge 1 commit intoapache:masterfrom
johnclara wants to merge 1 commit intoapache:masterfrom
Conversation
johnclara
force-pushed
the
manifestArrayList
branch
from
2914e34 to
cc24553
Compare
johnclara
force-pushed
the
manifestArrayList
branch
from
cc24553 to
aeda5e1
Compare
rdblue
reviewed
Nov 24, 2020
| .commit(); | ||
|
|
||
| List<ManifestFile> manifests = table.currentSnapshot().allManifests(); | ||
| List<ManifestFile> manifests = new ArrayList(table.currentSnapshot().allManifests()); |
Author
There was a problem hiding this comment.
@rdblue sorting isn't supported on immutable lists.
Sorry, I should've closed this earlier. I was thinking this morning that this definitely isn't worth the risk of changing
Sorry for the at
Author
|
not worth changing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From #1812
Trying to match with: https://github.com/apache/iceberg/blob/master/core/src/main/java/org/apache/iceberg/BaseSnapshot.java#L131
Not sure if this is worth the risk of changing. A couple of our tables have some really large manifest lists and I was wondering if the micro benchmark shows anything noticable