Hive: Enhance iceberg.hive.engine.enabled documentation#1902
Merged
rdblue merged 2 commits intoapache:masterfrom Dec 10, 2020
Merged
Hive: Enhance iceberg.hive.engine.enabled documentation#1902rdblue merged 2 commits intoapache:masterfrom
rdblue merged 2 commits intoapache:masterfrom
Conversation
massdosage
reviewed
Dec 10, 2020
Co-authored-by: Adrian Woodhead <massdosage@gmail.com>
massdosage
approved these changes
Dec 10, 2020
rdblue
reviewed
Dec 10, 2020
|
|
||
| ##### Hive Configuration | ||
| The value `iceberg.engine.hive.enabled` needs to be set to `true` and added to the Hive configuration file on the classpath of the application creating the table. This can be done by modifying the relevant `hive-site.xml`. Alternatively this can be done programmatically like so: | ||
| The value `iceberg.engine.hive.enabled` needs to be set to `true` and added to the Hive configuration file on the classpath of the application creating or modifying (altering, inserting etc.) the table. This can be done by modifying the relevant `hive-site.xml`. Alternatively this can be done programmatically like so: |
Contributor
There was a problem hiding this comment.
Should we set the table property when a table is created from Hive with this enabled? That way it would take effect for all engines by default.
Contributor
|
Looks good to me. The question I asked in a comment is not related to the PR, so I merged it. Thanks @pvary and @massdosage! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #1850 we need to enhance the documentation to mention that everyone modifying the table should use the
iceberg.engine.hive.enabledconfig so the Hive parameters are not removed from the table