Fix update partition spec with only rename changes#2007
Merged
rdblue merged 2 commits intoapache:masterfrom Dec 31, 2020
Merged
Fix update partition spec with only rename changes#2007rdblue merged 2 commits intoapache:masterfrom
rdblue merged 2 commits intoapache:masterfrom
Conversation
…w spec as incompatible one.
Collaborator
Author
|
@rdblue @aokolnychyi can you take a look? Thanks. |
rdblue
reviewed
Dec 30, 2020
| .truncate("id", 4, "id_trunc_4") | ||
| .build(); | ||
| Assert.assertEquals("should match evolved spec", evolvedSpec, table.spec()); | ||
| Assert.assertEquals(1002, table.spec().lastAssignedFieldId()); |
Contributor
There was a problem hiding this comment.
This seems like it should be its own test case. Could you move it?
rdblue
approved these changes
Dec 31, 2020
Contributor
|
Thanks, @jun-he! I merged this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix update partition spec with only rename changes by treating the new spec as incompatible one.