Remove unused test code in TestExpireSnapshotsAction#2024
Closed
zhangdove wants to merge 1 commit intoapache:masterfrom
Closed
Remove unused test code in TestExpireSnapshotsAction#2024zhangdove wants to merge 1 commit intoapache:masterfrom
zhangdove wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
I don't think that these changes are correct. The method that waits until after the last commit is intended to ensure that the timestamps work with the test assumptions. |
Contributor
Author
|
Thank you for your advice. I also noticed that the #1380 is to solve the problem of jet lag. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restudy the test case code of ExpireSnapshotsAction and find some unused code.