Flink: Use Namespace in FlinkCatalog.#2392
Merged
openinx merged 2 commits intoapache:masterfrom Mar 31, 2021
openinx:flink-catalog-use-namespace
Merged
Flink: Use Namespace in FlinkCatalog.#2392openinx merged 2 commits intoapache:masterfrom openinx:flink-catalog-use-namespace
openinx merged 2 commits intoapache:masterfrom
openinx:flink-catalog-use-namespace
Conversation
rdblue
reviewed
Mar 30, 2021
| return Namespace.of(namespace); | ||
| List<String> namespaces = Lists.newArrayListWithExpectedSize(baseNamespace.levels().length + 1); | ||
| Collections.addAll(namespaces, baseNamespace.levels()); | ||
| Collections.addAll(namespaces, database); |
Contributor
There was a problem hiding this comment.
Do you need to change the logic here to use a List? What about changing baseNamespace references to baseNamespace.levels()? That would be fewer changes.
rdblue
reviewed
Mar 30, 2021
| Namespace baseNamespace = Namespace.empty(); | ||
| if (properties.containsKey(BASE_NAMESPACE)) { | ||
| baseNamespace = Namespace.of(properties.get(BASE_NAMESPACE).split("\\.")); | ||
| } |
Contributor
There was a problem hiding this comment.
Why move this below cacheEnabled? That seems like it would cause unnecessary git conflicts.
rdblue
approved these changes
Mar 30, 2021
Contributor
rdblue
left a comment
rdblue
left a comment
There was a problem hiding this comment.
Overall this looks correct, but I had a couple of minor comments. Please merge once you have addressed those. Feel free to leave them as is if you feel strongly about the new implementation.
Member
Author
|
Got this merged, thanks @rdblue for reviewing. |
coolderli
pushed a commit
to coolderli/iceberg
that referenced
this pull request
Apr 26, 2021
stevenzwu
pushed a commit
to stevenzwu/iceberg
that referenced
this pull request
Jul 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This address the comment in FlinkCatalog