Nessie: change commit operation type#2411
Merged
rymurr merged 1 commit intoapache:masterfrom Apr 11, 2021
Merged
Conversation
This minor fix changes how the Nessie Table ops commits a table. Instead of using the single table commit endpoint, it will now use the multi-table endpoint. This is more stable long-term as the single table commit may be deprecated
snazy
approved these changes
Apr 9, 2021
Member
snazy
left a comment
snazy
left a comment
There was a problem hiding this comment.
LGTM
It's just using a different method, no functional change - so +1
Contributor
Author
|
Hey @aokolnychyi and @rdblue this is a minor nessie-only change thats been reviewed by a nessie dev. Can I merge it or should it be checked over by another Iceberg committer? |
stevenzwu
pushed a commit
to stevenzwu/iceberg
that referenced
this pull request
Jul 28, 2021
This minor fix changes how the Nessie Table ops commits a table. Instead of using the single table commit endpoint, it will now use the multi-table endpoint. This is more stable long-term as the single table commit may be deprecated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This minor fix changes how the Nessie Table ops commits a table. Instead of using the single table commit endpoint, it will now use the multi-table endpoint. This is more stable long-term as the single table commit may be deprecated.