Build: Support overwrite maven repo by gradle properties

[pan3793]

cc @RussellSpitzer

[RussellSpitzer]

I'm a little lost here, it looks like previously we could set this based on the -PmavenSnapshotsRepo and now we are switching it to a local property? Or does -P handle set the local property as well?

Mostly i'm confused why project.property was not sufficient before

[RussellSpitzer]

Groovy and Gradle still hold a lot of mysteries for me

[pan3793]

Overwrite snapshotsRepo by -PmavenSnapshotsRepo? Seems not work for me.

As my understand, before only handle mavenUser and mavenPassword by -P or local properties but hardcode repo urls.

Groovy and Gradle still hold a lot of mysteries for me

Big +1

[RussellSpitzer]

From my understanding project.property('mavenSnapshotsRepo') picks up properties from either a gradles.properties file or from -P args, I"ll run some tests to see

[pan3793]

yeap, and -P args should have the high priority.

[pan3793]

oh, i see. the inlined conversation diff looks weird, but File Changed page looks good.

[RussellSpitzer]

I'm still lost a bit I think

  def snapshotsRepoUrl = project.hasProperty('mavenSnapshotsRepo') ? "$mavenSnapshotsRepo" : "$apacheSnapshotsRepoUrl"

should be

  def snapshotsRepoUrl = project.hasProperty('mavenSnapshotsRepo') ? project.property("mavenSnapshotsRepo") : "$apacheSnapshotsRepoUrl"

When I do a quick test

print(project.hasProperty("mavenSnapshotsRepo"))
print(project.property("mavenSnapshotsRepo"))
print($mavenSnapshotsRepo)

and

 g -PmavenSnapshotsRepo=one

Then I get mavenSnapshotsRepo undefined but the first two work fine.

[pan3793]

print("$mavenSnapshotsRepo") works but print($mavenSnapshotsRepo) not.

"$mavenSnapshotsRepo" will fallback to project.property("mavenSnapshotsRepo")

[RussellSpitzer]

So this is some magic in the string interpolation?

[pan3793]

yes

[RussellSpitzer]

@aokolnychyi + @rdblue I haven't done a release so one of you should probably check it too :)

[rdblue]

Looks fine to me.