Refactor of RewriteDataFiles and BinPackStrategy#2600
Merged
aokolnychyi merged 2 commits intoapache:masterfrom May 17, 2021
Merged
Refactor of RewriteDataFiles and BinPackStrategy#2600aokolnychyi merged 2 commits intoapache:masterfrom
aokolnychyi merged 2 commits intoapache:masterfrom
Conversation
aokolnychyi
reviewed
May 17, 2021
aokolnychyi
reviewed
May 17, 2021
core/src/main/java/org/apache/iceberg/actions/BinPackStrategy.java
Outdated
Show resolved
Hide resolved
aokolnychyi
reviewed
May 17, 2021
core/src/main/java/org/apache/iceberg/actions/BinPackStrategy.java
Outdated
Show resolved
Hide resolved
aokolnychyi
approved these changes
May 17, 2021
Contributor
|
Thanks, @RussellSpitzer! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove explicit staregy api in Rewrite Data Files APi so that we can more easily add strategies with custom arguements, such as "sort(SortOrder ...)
Change BinPack Defaults and organization to better handle small and large files
Removes the output size parameter and replaces it with a constant check clause to see if the output of the rewrite would produce a target size file or the input exceeds the MIN_INPUT_FILES param