Add schema validation before table import #2736
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
flyrain
reviewed
Jul 7, 2021
Contributor
flyrain
left a comment
flyrain
left a comment
There was a problem hiding this comment.
Thanks for the PR. Out of curiosity, in which scenario, method importSparkTable will hit unmatched schema? In the other words, why do we need to check schema? Can we add a test case for that?
| try { | ||
| CatalogTable sourceCatalogTable = catalog.getTableMetadata(sourceTableIdent); | ||
| Preconditions.checkArgument(validateSchema(sourceCatalogTable.schema(), targetTable.schema()), | ||
| "The schemas of source table and target table dont match"); |
| } | ||
| } | ||
|
|
||
| static boolean validateSchema(StructType srcSchema, Schema tgtSchema) { |
Contributor
There was a problem hiding this comment.
Is it more suitable to put into SparkSchemaUtil?
|
|
||
| import static org.apache.iceberg.types.Types.NestedField.optional; | ||
|
|
||
| public class TestSparkTableUtil { |
Contributor
There was a problem hiding this comment.
Some test cases are more suitable for the method SparkSchemaUtil.convert since the method validateSchema didn't do a lot except invoking SparkSchemaUtil.convert() and StructType.equals().
kbendick
reviewed
Jul 16, 2021
| } | ||
|
|
||
| static boolean validateSchema(StructType srcSchema, Schema tgtSchema) { | ||
| StructType convertSchem = SparkSchemaUtil.convert(tgtSchema); |
Contributor
There was a problem hiding this comment.
Nit: convertSchema - missing last a in variable name.
Contributor
Author
|
This PR requires more changes, closing it for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.