Core: Validate planTasks and splitFiles in TableScanUtil#2759
Merged
aokolnychyi merged 1 commit intomasterfrom Jun 29, 2021
Merged
Core: Validate planTasks and splitFiles in TableScanUtil#2759aokolnychyi merged 1 commit intomasterfrom
aokolnychyi merged 1 commit intomasterfrom
Conversation
aokolnychyi
approved these changes
Jun 29, 2021
rdblue
approved these changes
Jun 29, 2021
Contributor
|
Let's remember to add Shardul as a co-author. |
Previously these values were not validated which could lead to a huge runtime issues or OOMs. To prevent errors we validate the parameters for these methods and prevent these issues from occuring. Co-authored-by: Shardul Mahadik <smahadik@linkedin.com>
RussellSpitzer
force-pushed
the
ValidateSplitPlanning
branch
from
b1822ba to
ea6f291
Compare
Member
Author
|
Added |
Contributor
|
Thanks, @RussellSpitzer @shardulm94 @rdblue! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously these values were not validated which could lead to a huge
runtime issues or OOMs. To prevent errors we validate the parameters
for these methods and prevent these issues from occuring.