API: Use delete instead of remove in actions for clarity#2810
Conversation
| * Returns the number of deleted data files. | ||
| */ | ||
| long removedDataFilesCount(); | ||
| long deletedDataFilesCount(); |
There was a problem hiding this comment.
Now it matches the naming in ExpireSnapshots.
The downside is that we will add deletedDeleteFilesCount in the future. I can live with that.
d2a5a29 to
c265e5b
Compare
|
@RussellSpitzer @flyrain @karuppayya @rdblue, I took a look at the current state of our new actions and I think it would make sense to switch from Let me know what you think. |
c265e5b to
b72841f
Compare
b72841f to
85b0738
Compare
|
My only worry here is we have two senses of delete in the API. Logical deletes and physical deletes, before the names were distinct since "delete" apis only did logical deletes while "remove" apis actually removed files from your file system. I also only worry about this on about a 2 out of 10 worry scale so i'm +1 on moving forward if @aokolnychyi feels strongly about it :) |
|
I'm okay with either remove or delete. |
|
My primary motivation is the inconsistency we have in the code right now. In three actions (including Karuppayya's original implementation called the action |
This PR switches our new actions to use
deleteinstead ofremoveas I thinkdeletemakes more sense given the naming of methods in these actions.This is NOT a breaking change as we modify only the unreleased Actions API.