Spark: Use JavaSparkContext.fromSparkContext instead of constructor#2812
Merged
aokolnychyi merged 1 commit intoapache:masterfrom Jul 13, 2021
Merged
Spark: Use JavaSparkContext.fromSparkContext instead of constructor#2812aokolnychyi merged 1 commit intoapache:masterfrom
aokolnychyi merged 1 commit intoapache:masterfrom
Conversation
aokolnychyi
changed the title
Contributor
Author
|
@RussellSpitzer, could you review this one? |
kbendick
approved these changes
Jul 12, 2021
Contributor
kbendick
left a comment
kbendick
left a comment
There was a problem hiding this comment.
This greatly enhances readability. Thanks Anton.
Contributor
Author
|
Thanks, @kbendick @RussellSpitzer! |
minchowang
pushed a commit
to minchowang/iceberg
that referenced
this pull request
Aug 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As @RussellSpitzer pointed out during reviews, it is better avoid calling
newto constructJavaSparkContextnot to mislead people as we are not actually creating a new context. Instead, we create a wrapper.This PR updates places that were committed before that.