Suppress invalid ErrorProne warnings related to calling getNano metho…#2999
Closed
kbendick wants to merge 2 commits intoapache:masterfrom
Closed
Suppress invalid ErrorProne warnings related to calling getNano metho…#2999kbendick wants to merge 2 commits intoapache:masterfrom
kbendick wants to merge 2 commits intoapache:masterfrom
Conversation
…ds without nearby getSeconds calls
…oesnt need to call getSeconds or setSeconds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ds without nearby getSeconds calls
As we set
nanosspecifically in a field, these warning do not apply. Remove them from the logs.Also removed one instance of it in
hive3/src/main/java/org/apache/iceberg/mr/hive/serde/objectinspector/IcebergTimestampObjectInspectorHive3.#getPrimitiveJavaObject. I checked manually in a scala shell with the hive classes in it (placing the Iceberg jar on the classpath) that the call to getNanos is correct.