Arrow: Add BaseBatchReader and reduce code duplication #3123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdblue
reviewed
Sep 19, 2021
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/BaseBatchReader.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Sep 19, 2021
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/BaseBatchReader.java
Outdated
Show resolved
Hide resolved
rdblue
requested changes
Sep 19, 2021
Contributor
rdblue
left a comment
rdblue
left a comment
There was a problem hiding this comment.
Looks ready to me, other than the method names that need to be fixed.
nastra
force-pushed
the
arrow-base-batchreader
branch
from
1af07c5 to
31d9de6
Compare
rdblue
approved these changes
Sep 20, 2021
Contributor
|
Thanks @nastra! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.