Spark: Rewrite adjust check group count before to group stream #3173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xloya
changed the title
xloya
changed the title
rdblue
approved these changes
Sep 26, 2021
Contributor
|
Looks correct to me. Kicking off CI. |
RussellSpitzer
approved these changes
Sep 27, 2021
Member
RussellSpitzer
left a comment
RussellSpitzer
left a comment
There was a problem hiding this comment.
Looks good to me as well, I think the stream is lazy here but this shouldn't hurt
Contributor
|
Thanks, @xloya! |
Contributor
Author
|
Thanks for your time, @rdblue @RussellSpitzer ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be checked whether there is no need to rewrite before calling the
toGroupStream()method, so as to reduce the code logic that does not need to be rewritten.cc @RussellSpitzer @rdblue @aokolnychyi